Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defmt project with esp-backtrace changes #36

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

SergioGasquez
Copy link
Member

Maybe we should not merge this until a new release of esp-bactrace is out and we can remove the patch?

@SergioGasquez SergioGasquez linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I agree on deferring the merge ... having patches in the training material probably causes a lot of confusion

@SergioGasquez SergioGasquez marked this pull request as draft January 31, 2024 08:54
@SergioGasquez SergioGasquez marked this pull request as ready for review February 12, 2024 09:25
@SergioGasquez
Copy link
Member Author

Removed the patch and updated the deps of the other projects!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this - having this up-to-date makes life of new comers much easier

@SergioGasquez SergioGasquez merged commit 1ffbab8 into esp-rs:main Feb 12, 2024
10 checks passed
@SergioGasquez SergioGasquez deleted the feat/update-defmt branch February 12, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defmt example
2 participants