Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing wifi event WIFI_EVENT_HOME_CHANNEL_CHANGE #352

Closed

Conversation

1HPorange
Copy link

Hi,

Somehow this event was missing for me. It seems to be here, and my home WIFI setup triggers it consistently with the basic connect example, so I need this patch to get around the panic.

@1HPorange
Copy link
Author

Oh, seems i need to version gate this somehow, how do you prefer that to be done?

@Vollbrecht
Copy link
Collaborator

What version of esp-idf are you using? I can't imagine that esp is currently triggering it, as you see it was added here relatively recently and this commit also touches all the proprietary wifi blobs, so it is not included in any released esp-idf version.

I mean yes your router can try force a channel switch non-stop, but that should be independent of that event.

Anyway if that lands on one of the release versions its fine to futureproof, in general we import via conditional cfg's with respect to the taged semver versions of the esp-idf. Example here if worst come to worst this way, otherwise if there is a clean point where they only have it for newer versions and dont backport it, it might just one cfg point to include it.

@1HPorange
Copy link
Author

I am using a the espressif idf dev container espressif/idf:latest. The reported version is ESP-IDF v5.3-dev-1353-gb3f7e2c8a4.

I might have gone a bit too "bleeding edge" :) After reading your thoughts it's probably best to wait before including this event, which might not even land.

@1HPorange 1HPorange closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants