Tidy up Camera according to latest guidelines
#3237
+275
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rursprung
reviewed
Mar 10, 2025
| + config.with_enable_2byte_mode(true) // If you were previously using RxSixteenBits | ||
| )?; | ||
|
|
||
| + camera.with_data0(peripherals.GPIO11).with_data1(peripherals.GPIO9).with_dataX(); |
There was a problem hiding this comment.
this isn't so much about the PR and more about an issue i have with the dev. guidelines which is very well outlined in this PR: in the current API you have to use all data pins. but with the new API introduces with this PR there's now the real risk that you forget to pass one of the data pins. finding this bug is much more cumbersome with the new API.
what is the rationale for this design choice? have these downsides been considered and what can be done to mitigate them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
All
Camerapins are now configured usingwith_*()methods.Some implicit config has now been made explicit to make this change possible.
Not sure if there's a preference between
with_vertical_syncandwith_vsyncbut I chose the latter for now. (Happy to change it).Testing
Ran the qa-test and I'm entrusting the HIL test to CI.