Fix dropped packets in get_names #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Becuase OTP 17 was not playing well with
`epmd -names` -- it was inconistantly returning
the [s]names when there were nodes assigned to
ports -- taking a look at the doc for gen_tcp
clued me into a possible issue:
As far as I can tell, when a socket is
`{active, false}` and `{packet, raw|0}` has been
set (via inet or otherwise), the `gen_tcp:recv`
routine ought to loop to receive all the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Becuase OTP 17 was not playing well with
epmd -names-- it was inconistantly returningthe [s]names when there were nodes assigned to
ports -- taking a look at the doc for gen_tcp
clued me into a possible issue:
As far as I can tell, when a socket is
{active, false}and{packet, raw|0}has beenset (via inet or otherwise), the
gen_tcp:recvroutine ought to loop to receive all the data.