Moving src/External
#414
Merged
Moving src/External
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
The idea is to decouple the minimum set of required fortran flags to get Enzo-E to compile from any other fortran-flags specified in the machine-files. This isn't used quite yet
As part of this commit, I needed to removed the flags from the existing machine files.
I now returns a list of compilation flags (wrapped in appropriate generator expressions)
It was moved to earlier in the file. The idea is to insolate compilation of "vendored dependencies" from the arbitrary flags that users specify for building Enzo-E/Cello. In practice, this doesn't matter right now. But in the future, it could matter a lot more! For example a dependency could entirely break when, -> using unsafe-floating point optimizations... -> using compiler-flags to properly handle Enzo-E's fortran dialect
The purpose of these variables is to act similarly to the standard ``CMAKE_<LANG>_FLAGS`` variables, but only affect the source files directly used by Cello/Enzo-E. (The whole idea is to explicitly avoid is this new set of variables won't affect any external dependencies that is being compiled as a part of this build)
mabruzzo
force-pushed
the
move-src/External
branch
from
d111db0 to
2c85225
Compare
|
This looks good to me -- I left a few minor comments. |
gregbryan
approved these changes
Jun 24, 2024
| set(CMAKE_Fortran_FLAGS "-ffixed-line-length-132" CACHE STRING "Default Fortran flags") | ||
|
|
||
| # the minimal set of required flags to successfully compile with this Fortran | ||
| # compiler are handled internally (if those flags don't work, please update |
There was a problem hiding this comment.
It may not be immediately clear to someone trying to compile what "internal" means here (I assume this refers to RequiredFortranCompileOptions.cmake or similar) -- maybe point to docs or somewhere to give user some help?
|
Thanks @bwoshea for taking the lead on patching this up. I was a little distracted over the past few days |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request summary
This PR moves the location of the external files out of
src/Externalinto the newly-created root-levelexternal/pngwriterdirectory.Detailed Description
This change is mostly cosmetic.
I also removed
external/pngwriter/external.dirFinally, I made a few minor tweaks to
external/pngwriter/CMakeLists.txtso that it looks and acts a little more like aCMakeLists.txtfile of a standalone project.This is a major change or addition (that needs 2 reviewers): no