-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: abort filter chain after reset stream was called #31775
http: abort filter chain after reset stream was called #31775
Conversation
Signed-off-by: wbpcode <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change. Please runtime guard just in case though, include on release notes and tag both if we should backport, and if we think this needs to land before the release
/wait
cc @phlax @RyanTheOptimist @yanavlasov for release context |
Signed-off-by: wbpcode <[email protected]>
It take too much time to run these tests on my PC. Let the ci check it. orz |
hmmm, I just realized it's possible we need to do the same here for the 2 other resetStream calls in the filter_manager so have You want to fix or shall I? |
@alyssawilk I knew that code when I doing the fix. The change is optional because the sendLocalReply self will handle the status correctly. Basically, I treat the Anyway, it's up to you. Changing it should also be harmless. :) |
Commit Message: http: abort filter chain after reset stream was called
Additional Description:
To close #26994. The #26994 is caused by that the filter chain still continue and try to send reply after the whole stream is closed. We should abort the filter chain to avoid any possible further logic after the stream is reset.
Also see #30835 for more context.
Risk Level: low.
Testing: integration.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.