mobile: Add an RTDS integration test with dfp_mixed_scheme #31364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Beyad <[email protected]>
|
ah - conflict - i saw the pr failing request and was worried - i can add some fail handling for that - but i think all good |
RyanTheOptimist
previously approved these changes
Dec 13, 2023
Signed-off-by: Ali Beyad <[email protected]>
RyanTheOptimist
previously approved these changes
Dec 14, 2023
|
Looks like a real test failure? https://github.com/envoyproxy/envoy/actions/runs/7201881774/job/19618907200 |
yep it is, I was debugging this and found another issue that needs fixing. |
|
/wait |
Signed-off-by: Ali Beyad <[email protected]>
Signed-off-by: Ali Beyad <[email protected]>
RyanTheOptimist
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this change, a new test Runtime was added:
TestScopedStaticReloadableFeaturesRuntime.It should be used in build environments, like Envoy Mobile, where the admin layer is not available (which
is required by TestScopedRuntime).