Read MapBox API token at runtime #11889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
requested review from
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
Frizi,
farmaazon,
kazcw and
AdRiley
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
Frizi
approved these changes
Dec 17, 2024
| node.href = url | ||
| node.rel = 'stylesheet' | ||
| } else if (type === 'scripts') { | ||
| assert(node instanceof HTMLScriptElement) |
There was a problem hiding this comment.
This should be a console error and a graceful continue instead of an assert. The visualizations code needs to be treated as user input.
There was a problem hiding this comment.
The node here is created a few lines above depending on the type variable, and the assert plays the role of a safe type coercion.
| const nodeKind = type === 'scripts' ? 'script' : 'link' | ||
| const node = document.createElement(nodeKind) | ||
| if (type === 'styles') { | ||
| assert(node instanceof HTMLLinkElement) |
There was a problem hiding this comment.
Same here, don't assert in what's effectively a user input parsing code.
jdunkerley
pushed a commit
that referenced
this pull request
Dec 18, 2024
* Read mapbox API token at runtime, fix scaling issue * Load styles the same way as scripts * remove mapbox dependency * Update changelog (cherry picked from commit c2059be)
somebody1234
pushed a commit
that referenced
this pull request
Dec 24, 2024
* Read mapbox API token at runtime, fix scaling issue * Load styles the same way as scripts * remove mapbox dependency * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #10808
The
ENSO_IDE_MAPBOX_API_TOKENenvironment variable must be provided at runtime if one wants to use geomap visualization. I also bumped the version of mapbox and implemented async CSS loading in the same way we loaded custom JS for visualizations.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.