Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fantom and max gas fee calculation #639

Open
wants to merge 6 commits into
base: devop/pakage-updates
Choose a base branch
from

Conversation

gamalielhere
Copy link
Contributor

@gamalielhere gamalielhere commented Mar 14, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced the transaction process by introducing a faster fee option for Fantom network users.
    • Maintained existing fee settings for other networks to ensure a consistent experience.
  • Chores
    • Updated various dependencies and development dependencies across multiple packages to their latest versions for improved performance and compatibility.

kvhnuke and others added 2 commits March 11, 2025 15:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Release: v2.4.3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

coderabbitai bot commented Mar 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • develop
  • devop/vite-migrate

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The change updates the fee selection logic in the send transaction UI component. A conditional check for setting the selectedFee variable now includes an additional branch for the Fantom network. If the network is Fantom, the fee is set to GasPriceTypes.FASTEST. The logic continues to assign GasPriceTypes.REGULAR for Ethereum and Binance networks and GasPriceTypes.ECONOMY for other networks. Additionally, several package.json files across different packages have been updated to reflect new versions of dependencies and development dependencies.

Changes

File Path Change Summary
packages/extension/src/.../send-transaction/index.vue Modified fee selection logic: now sets selectedFee to GasPriceTypes.FASTEST for Fantom networks while retaining REGULAR for Ethereum/Binance and ECONOMY otherwise.
package.json Updated versions of @commitlint/cli, @commitlint/config-conventional, and @swc/core.
packages/extension-bridge/package.json Updated versions of @types/node, @types/webextension-polyfill, bumpp, eslint, tsup, type-fest, typescript, and typescript-eslint.
packages/extension/package.json Updated various dependencies including @amplitude/analytics-browser, @kadena/client, @kadena/pactjs-cli, and several @polkadot packages.
packages/hw-wallets/package.json Updated versions of @types/node, eslint, prettier, typescript, and @ledgerhq packages.
packages/keyring/package.json Updated versions of @polkadot/util and various devDependencies.
packages/name-resolution/package.json Updated versions of @types/node, eslint, prettier, tsup, typescript, typescript-eslint, vitest, and ethers.
packages/request/package.json Updated versions of uuid, ws, and several devDependencies.
packages/signers/bitcoin/package.json Updated various devDependencies including @types/node, eslint, prettier, tsup, typescript, typescript-eslint, and vitest.
packages/signers/ethereum/package.json Updated various devDependencies including @types/node, eslint, prettier, tsup, typescript, typescript-eslint, and vitest.
packages/signers/kadena/package.json Updated versions of @polkadot/util-crypto and various devDependencies.
packages/signers/polkadot/package.json Updated versions of @commitlint/cli, @polkadot/util, @polkadot/util-crypto, and various devDependencies.
packages/storage/package.json Updated versions of @types/node, eslint, prettier, tsup, typescript, and typescript-eslint.
packages/swap/package.json Updated versions of @solana/spl-token, rango-sdk-basic, uuid, ws, and various devDependencies.
packages/types/package.json Updated versions of @types/node, eslint, prettier, tsup, and typescript.
packages/utils/package.json Updated versions of @polkadot/util-crypto and various devDependencies.

Sequence Diagram(s)

Loading
sequenceDiagram
    participant UI as SendTransaction Component
    participant Logic as Fee Selection Logic

    UI->>Logic: Determine gas fee based on network type
    alt Network is Ethereum or Binance
        Logic-->>UI: Return REGULAR fee
    else if Network is Fantom
        Logic-->>UI: Return FASTEST fee
    else
        Logic-->>UI: Return ECONOMY fee
    end

Possibly related PRs

  • Fix/sending nft fee calc #581: The changes in the main PR are related to those in the retrieved PR as both modify the packages/extension/src/providers/ethereum/ui/send-transaction/index.vue file, specifically enhancing logic related to transaction fees and balance validation.
  • Fix/copy #598: The changes in the main PR are related to the modifications in the send-transaction component, specifically the introduction of the RecentlySentAddressesState class and its integration into the transaction process, which aligns with the updates in the retrieved PR that also involve similar enhancements in tracking and managing addresses.

Suggested reviewers

  • olgakup

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Mar 14, 2025

💼 Build Files
chrome: enkrypt-chrome-9fed4d76.zip
firefox: enkrypt-firefox-9fed4d76.zip

💉 Virus total analysis
chrome: 9fed4d76
firefox: 9fed4d76

@gamalielhere gamalielhere changed the base branch from main to develop March 14, 2025 19:40
…into fix/ftm-underpriced
@kvhnuke kvhnuke changed the base branch from develop to devop/pakage-updates March 20, 2025 17:19
@kvhnuke kvhnuke changed the title fix: set fantom send to fastest fix: fantom and max gas fee calculation Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants