feat: update 0x api to reflect new changes

[gamalielhere]

Summary by CodeRabbit

• New Features
  • Introduced a refined fee structure for swap transactions, offering clearer fee calculations.
• Chores
  • Removed legacy fee configuration settings to streamline fee processing.

[coderabbitai]

Warning

Rate limit exceeded

@gamalielhere has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 80678e5 and 099007e.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (15)

• package.json (1 hunks)
• packages/extension-bridge/package.json (1 hunks)
• packages/extension/package.json (4 hunks)
• packages/hw-wallets/package.json (2 hunks)
• packages/keyring/package.json (1 hunks)
• packages/name-resolution/package.json (2 hunks)
• packages/request/package.json (1 hunks)
• packages/signers/bitcoin/package.json (1 hunks)
• packages/signers/ethereum/package.json (1 hunks)
• packages/signers/kadena/package.json (1 hunks)
• packages/signers/polkadot/package.json (1 hunks)
• packages/storage/package.json (1 hunks)
• packages/swap/package.json (1 hunks)
• packages/types/package.json (1 hunks)
• packages/utils/package.json (1 hunks)

Walkthrough

The changes update the fee-handling logic in the getZeroXSwap method of the ZeroX provider. New fee parameters are calculated (using bpsFee and feeContract) and added to the request parameters. Specifically, three properties—swapFeeBps, swapFeeToken, and swapFeeRecipient—are added, while buyTokenPercentageFee and feeRecipient are removed. The modifications clarify how fee data is structured for swap requests without altering the primary logic flow.

Changes

File	Change Summary
packages/swap/src/providers/zerox/index.ts	- Introduced new fee variables (bpsFee and feeContract) in the getZeroXSwap method. - Added parameters: swapFeeBps, swapFeeToken, and swapFeeRecipient. - Removed parameters: buyTokenPercentageFee and feeRecipient.

Sequence Diagram(s)

Loading

sequenceDiagram
    participant C as Caller
    participant Z as ZeroX.getZeroXSwap
    participant API as API Request

    C->>Z: Call getZeroXSwap(feeConfig, toToken, ...)
    Z->>Z: Compute bpsFee from feeConfig fee value
    Z->>Z: Set feeContract using toToken address
    Z->>Z: Assemble params with swapFeeBps, swapFeeToken, swapFeeRecipient
    Z->>API: Send API request with updated parameters
    API-->>Z: Return swap response
    Z-->>C: Return swap quote

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

💼 Build Files
chrome: enkrypt-chrome-099007ea.zip
firefox: enkrypt-firefox-099007ea.zip

💉 Virus total analysis
chrome: 099007ea
firefox: 099007ea

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/swap/src/providers/zerox/index.ts (2)

153-154: Add semicolon and consider clarifying fee calculation

I noticed a missing semicolon at the end of line 154 which should be added for consistency. Additionally, the fee calculation on line 153 is quite complex - it's converting a percentage to basis points (BPS) with specific formatting. Consider adding a comment explaining this conversion logic for clarity.

const bpsFee = parseFloat((feeConfig.fee * 100).toFixed(4)) * 100;
-const feeContract = options.toToken.address
+const feeContract = options.toToken.address;

---

159-162: LGTM: Updated fee parameters for 0x API

The changes correctly implement the updated fee parameter structure required by the 0x API. The code now uses swapFeeBps, swapFeeToken, and swapFeeRecipient instead of the previous parameters.

There's some inconsistency in how feeConfig is null-checked though - line 153 uses it directly while line 161 performs a conditional check. Consider standardizing this approach.

swapFeeBps: bpsFee.toString(),
swapFeeToken: feeContract,
-swapFeeRecipient: feeConfig ? feeConfig.referrer : "",
+swapFeeRecipient: feeConfig.referrer,

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 048f6f5 and ab3bc1d.

📒 Files selected for processing (1)

• packages/swap/src/providers/zerox/index.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: buildAll
• GitHub Check: test