Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: klayton and images #624

Merged
merged 5 commits into from
Mar 10, 2025
Merged

fix: klayton and images #624

merged 5 commits into from
Mar 10, 2025

Conversation

kvhnuke
Copy link
Contributor

@kvhnuke kvhnuke commented Feb 28, 2025

Summary by CodeRabbit

  • New Features

    • Introduced support for the Kaia network, replacing the previous Klaytn configuration to provide updated network options.
  • Bug Fixes

    • Updated the Scroll network connection to use a WebSocket endpoint for improved communication.
    • Enhanced token icon validation to ensure that icons display only when valid image URLs are available.
  • Refactor

    • Updated references and configurations related to the Klaytn network, transitioning to the Kaia network across various components and types.

Copy link

coderabbitai bot commented Feb 28, 2025

Walkthrough

This pull request updates network configurations by replacing references to “Klaytn” with “Kaia” across multiple modules. The changes adjust the supported network entries, type definitions, and export mappings for Ethereum. A new file defining the Kaia network configuration is added while the existing Klaytn configuration is removed. Additionally, the Scroll network’s node URL is changed from an HTTP endpoint to a WebSocket endpoint, and a minor conditional check is added in the Solana API to ensure the token icon is only set when a valid URI is present. Relevant enum entries have also been updated accordingly.

Changes

File(s) Change Summary
packages/extension/.../assets-handlers/assetinfo-mew.ts
packages/extension/.../assets-handlers/types/tokenbalance-mew.ts
Updated network entry from NetworkNames.Klaytn to NetworkNames.Kaia and adjusted the associated cgPlatform and type definitions.
packages/extension/.../networks/index.ts Replaced import and export: removed klayNode and its key klaytn, added kaiaNode with key kaia.
packages/extension/.../networks/kaia.ts
packages/extension/.../networks/klay.ts
Added the new Kaia network configuration and removed the Klaytn network configuration file.
packages/extension/.../networks/scroll.ts Updated the node property in scrollOptions from an HTTP URL to a WebSocket URL.
packages/extension/.../solana/libs/api.ts Introduced an additional condition to validate that the first file’s uri is truthy before assigning the token icon.
packages/types/src/networks.ts Modified enum entries, renaming Klaytn to Kaia in both NetworkNames and CoingeckoPlatform.
packages/swap/src/types/index.ts Updated SupportedNetworkName enum by replacing Klaytn with Kaia.
packages/hw-wallets/package.json Updated dependency versions for @trezor/connect and @trezor/connect-webextension from ^9.4.7 to ^9.5.1.
packages/extension/package.json Updated package version of @enkryptcom/extension from 2.4.1 to 2.4.2.
packages/swap/src/common/supportedNetworks.ts Removed entry for SupportedNetworkName.Klaytn and added entry for SupportedNetworkName.Kaia with updated properties.

Possibly related PRs

  • Release: v2.4.0 #614: The changes in the main PR are related to the modifications of network names and configurations for Klaytn and Kaia, which are also reflected in the retrieved PR's updates to the network handling logic and related components.
  • Feat/new update UI #595: The changes in the main PR are related to the modifications of network names and types, which directly connect to the updates in the NetworkNames enum in the retrieved PR, specifically regarding the transition from Klaytn to Kaia.

Suggested Reviewers

  • NickKelly1
  • gamalielhere
  • olgakup

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04ed22e and 1ced5be.

📒 Files selected for processing (1)
  • packages/extension/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/extension/package.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: buildAll
  • GitHub Check: test

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Feb 28, 2025

💼 Build Files
chrome: enkrypt-chrome-1ced5be6.zip
firefox: enkrypt-firefox-1ced5be6.zip

💉 Virus total analysis
chrome: 1ced5be6
firefox: 1ced5be6

@kvhnuke kvhnuke merged commit e3fca1e into develop Mar 10, 2025
4 checks passed
@kvhnuke kvhnuke deleted the devop/fix-klay branch March 10, 2025 23:09
This was referenced Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants