Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update sqlalchemy core tutorial link #517

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

njanke96
Copy link
Contributor

The current link in the docs (specifying the version "latest") now points to the docs for the SQLAlchemy 2.0 beta. This PR changes the link to strictly specify version 1.4.

It would also be possible to change the link to point to "stable" rather than "latest", however 1.4 seemed more appropriate as "stable" will likely point to 2.0 before this library migrates.

Cheers

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The current link in the docs (specifying the version "latest") now points to the docs for the SQLAlchemy 2.0 beta. This PR changes the link to strictly specify version 1.4.

It would also be possible to change the link to point to "stable" rather than "latest", however 1.4 seemed more appropriate as "stable" will likely point to 2.0 before this library migrates.

Cheers
Copy link
Member

@rafalp rafalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change until SQLAlchemy 2.0 stabilises and library is updated to support it.

Can you please update on master so I can merge it? Thanks!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge master
@njanke96
Copy link
Contributor Author

njanke96 commented Dec 1, 2022

Updated

@rafalp rafalp merged commit 8ec9168 into encode:master Dec 1, 2022
@rafalp
Copy link
Member

rafalp commented Dec 1, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants