Increase timeout for benchmark test to 1440 minutes (24 hours) #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianliebig
requested review from
Scienfitz,
AdrianSosic and
AVHopp
as code owners
Scienfitz
approved these changes
Mar 3, 2025
AdrianSosic
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, as one of the requested changes from #493, this PR sets the GitHub-side runtime limit for the container to 24 hours. This refers to the GITHUB_TOKEN generated per job, which expires after that time period. I've also tested longer runtimes and found that we should also be safe to go up to 35 days if necessary. Further changes regarding parallelization may follow once discussed.