Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-version plotting & SMOKE_TEST #111

Merged
merged 20 commits into from
Feb 19, 2024
Merged

Multi-version plotting & SMOKE_TEST #111

merged 20 commits into from
Feb 19, 2024

Conversation

AVHopp
Copy link
Collaborator

@AVHopp AVHopp commented Feb 2, 2024

This PR introduces including plots in the examples in light and dark version.

The requirement is that suitable .svg files are contained in the corresponding example folders. These need to be named like the example itself, together with "_light" and "_dark". Note that both of these files need to be present.
In addition, this PR changes the botorch_analytical.py example to show how corresponding files can be created automatically using a pre-defined .json. Furthermore, the file is changed in such a way to demonstrate the use of a SMOKE_TEST environment variable.

@AVHopp AVHopp added the documentation Improvements or additions to documentation label Feb 2, 2024
@AVHopp AVHopp self-assigned this Feb 2, 2024
@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from b3c9ae2 to 185d682 Compare February 2, 2024 13:48
@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch 2 times, most recently from 19910a7 to b1f6faf Compare February 2, 2024 17:26
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments

@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from 2f230a1 to 5ecd3cc Compare February 7, 2024 10:08
@AVHopp
Copy link
Collaborator Author

AVHopp commented Feb 7, 2024

@AdrianSosic @Scienfitz I force pushed the newest version. Please have a very quick look if this is gucci for you and ping me if this can be merged. Explicitly re-asking due to the upload of the svg files and how the potential override of files is handled.

@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from 5ecd3cc to bb654f5 Compare February 12, 2024 13:30
@AVHopp
Copy link
Collaborator Author

AVHopp commented Feb 12, 2024

@AdrianSosic I am finally done with this. Some things have changed a bit:

  1. The plots are not created if SMOKE_TEST is set, the function then just returns: If we just want to test the code, there is no need to create plots. Also, this avoids some complicated handling of the paths and stuff due to the files being executed as python files and jupyter files.
  2. I have included a warning if no kwargs are given.
  3. There was a mypy import error that I did not undestand completely. I included an ignore_missing_imports and hope that this was done in the correct way. Please check!
  4. When running tox locally, there was some error regarding the import of the baybe.plotting submodule.

If you are happy with the current version, feel free to just merge.

@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch 2 times, most recently from 515ff34 to 63288de Compare February 12, 2024 14:33
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AVHopp, due to the new changes, there a couple (minor) open issues.

@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from 63288de to 999555a Compare February 13, 2024 15:49
Copy link
Collaborator

@Scienfitz Scienfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resetting the review and will reevaluate

@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from 70c5fad to b8b8500 Compare February 15, 2024 09:57
@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from b8b8500 to 6dad852 Compare February 15, 2024 11:56
@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from 18f507d to befed82 Compare February 16, 2024 09:39
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will simply approve to unblock you. There's one minor open issue with the lazy imports that you guys still need to figure out. Other than that, I didn't fully follow your other conversations because of my absence, so I'll simply trust you there ;)

@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from caf247d to 7170a9f Compare February 16, 2024 14:50
@AVHopp AVHopp force-pushed the docs/enhanced_plotting branch from 6b7b76b to 5de7c42 Compare February 16, 2024 16:26
@AVHopp AVHopp merged commit a4fc897 into main Feb 19, 2024
9 checks passed
@AVHopp AVHopp deleted the docs/enhanced_plotting branch February 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants