Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

Blog: Sidebar and Meta Tag enhancements #3280

Merged
merged 11 commits into from
May 21, 2018
Merged

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Apr 14, 2018

  • Added more content to the side bar
  • added tags to blog posts: every post will have at least the year and the relevant Ember version
  • added responsive: true if it wasn't already there (it is still an issue but we don't know why, someone will have to sit down and figure it out)
  • moved the sidebar to the right (on smaller viewports, the sidebar moves below the content)
  • updated the visual design for the sidebar

If merged, the current blog:
image

Would now become this:
image

@locks locks temporarily deployed to ember-website-staging-pr-3280 April 14, 2018 19:19 Inactive
@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 April 14, 2018 19:27 Inactive
@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 April 14, 2018 19:32 Inactive
@MelSumner MelSumner requested a review from a team May 5, 2018 17:50
@MelSumner MelSumner changed the title [work in progress/experiment - do not merge] Blog: make it easier to read other posts May 5, 2018
@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 15:31 Inactive
@MelSumner MelSumner changed the title Blog: make it easier to read other posts Blog: Sidebar and Meta Tag enhancements May 21, 2018
@sivakumar-kailasam
Copy link
Member

@MelSumner on mobile the regular blog pages seems fine. When viewing one of the tags, it seems like its lacking media queries on those pages.

All screenshots were taken on a pixel 2 xl,
https://ember-website-staging-pr-3280.herokuapp.com/blog/page/2/
ember-website-staging-pr-3280 herokuapp com_blog_page_2_ pixel 2 xl

https://ember-website-staging-pr-3280.herokuapp.com/blog/tags/2018.html

ember-website-staging-pr-3280 herokuapp com_blog_tags_2018 html pixel 2 xl

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 15:52 Inactive
@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 15:53 Inactive
@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 16:20 Inactive
@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 16:38 Inactive
@MelSumner
Copy link
Contributor Author

@sivakumar-kailasam thanks for catching that, I needed to update the tab.html.erb to more accurately reflect current design. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants