-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove backticks around the id, for consistent formatting
Original PR for reference :) emberjs/ember.js#14590 |
@locks According to this https://www.emberjs.com/blog/2018/01/01/ember-2-18-released.html#toc_changes-in-ember-js-2-18 it is since 2.18.0 and until 3.5.0 |
@locks can you remove backticks around the id? It is a small thing but makes future CSS easier. Also while you're at it, can you promote I totally used |
@jenweber done |
I noticed an issue with using backticks in the deprecation title too, but it's a styling problem that affects other listings so I'll open a separate PR/Issue |
Complements emberjs/ember.js#14590.