Deprecate old manager capabilities versions #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, please! |
rwjblue
reviewed
Nov 30, 2020
Comment on lines
+155
to
+157
| - There will be some minor churn in the ecosystem as managers update, but this | ||
| is outweighed by the lowered maintenance burden in general for this | ||
| functionality. |
There was a problem hiding this comment.
FWIW, this is a significant issue. Since updating ember-modifer to use 3.22 capabilities is a breaking change and ember-cli does not currently support (not well at least) having multiple versions of a given package in the build we have to do a bit of hoop jumping to accomodate this.
Regardless, I think we should do this, but ^ is a very real issue that will need to be addressed before the actual deprecation lands.
|
The framework team discussed this RFC at the last meeting and decided to move it into FCP. Please leave your final comments |
|
The team discussed it again at the last meeting and decided to move forward and accept the RFC. Thank you for participating! |
delete-merged-branch
bot
deleted the
deprecate-old-manager-capabilities-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered