Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate tryinvoke #673

Merged
merged 15 commits into from
Nov 7, 2020
Merged

deprecate tryinvoke #673

merged 15 commits into from
Nov 7, 2020

Conversation

bachvo
Copy link
Contributor

@bachvo bachvo commented Oct 5, 2020

Building on RFC #0554: Deprecate getWithDefault, deprecate tryInvoke as well.

Rendered

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for working on it!

@rwjblue rwjblue self-assigned this Oct 5, 2020
@rwjblue rwjblue added T-deprecation T-framework RFCs that impact the ember.js library labels Oct 5, 2020
@chriskrycho
Copy link
Contributor

Thank you for writing this up! I'm excited!

@pzuraq
Copy link
Contributor

pzuraq commented Oct 9, 2020

We discussed this in the core team meeting today, and are happy with the direction of this RFC. There was one requested change, which is that we should have a more thorough "How we teach this section". Specifically:

  1. It should have the prose that should be added to the deprecation guide itself, including before and after examples

  2. Currently, we do not use tryInvoke in the Ember guides. However, it's a common question that new Ember users are asking, especially with Ember Octane now that actions are passed down directly as functions. We should add a section to the guides which uses optional chaining to demonstrate how to handle optional actions. This could be added to the actions section of the Component guides, and some prose for this would be good to add here.

Once those are addressed we can review it again. Thanks again for working on this!

@rwjblue
Copy link
Member

rwjblue commented Oct 23, 2020

We chatted about this in today's team meeting, and are happy to move this into the final comment period.

sandydoo added a commit to sandydoo/ember-google-maps that referenced this pull request Oct 23, 2020
@locks
Copy link
Contributor

locks commented Nov 7, 2020

We discussed this RFC at this week's framework team meeting and decided to move the RFC forward.
Thank you @bachvo and all commenters for participating in the process!

@locks locks merged commit 515e2f2 into emberjs:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period T-deprecation T-framework RFCs that impact the ember.js library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants