-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate mouseEnter/Leave/Move Ember events #486
Conversation
b1f575c
to
321566e
Compare
321566e
to
37ae192
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes :)
Thoughts on also adding |
Thanks for putting this together @simonihmig! |
Yes, I mentioned this under "Alternatives", and personally would be inclined to also include this! Here's a profiler view when just moving the mouse over an Ember app: The first two scripting executions (mouseout + mouseover) are for mouseenter/leave support, the third is just the normal event listener for mousemove. All these take just a fraction of a millisecond, though at large scale it looks like this: 😕 |
Co-Authored-By: Jessica Jordan <[email protected]>
@simonihmig - Would you mind updating to include |
Ah, sorry for the confusion thank you @simonihmig! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this a bit during a recent weekly call, and would love to see some tweaks to the examples.
Co-Authored-By: Clemens M�ller <[email protected]>
Discussed this at today's team meeting, and are 👍 on moving this into final comment period. |
Updated this to
|
At today's core team meeting, we have decided to move forward with this RFC. 👍 |
Rendered