[FEATURE] Add a --route-authoring-format option to the route generator
#20835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
commented
Jan 23, 2025
Windvis
commented
Jan 23, 2025
Windvis
commented
Jan 23, 2025
blueprints/route/files/__root__/__templatepath__/__templatename__.gts
Outdated
Show resolved
Hide resolved
Windvis
commented
Jan 23, 2025
Windvis
force-pushed
the
strict-route-templates-blueprint-support
branch
from
14cad41 to
9a0a990
Compare
|
I've added this to the agenda for us to discuss a name on tuesday. thanks for working on this!!! |
Windvis
force-pushed
the
strict-route-templates-blueprint-support
branch
from
9a0a990 to
975bd95
Compare
Windvis
changed the title
--strict-template option to the route generator--strict-route-template option to the route generator
3 tasks
ember-cli is used in the tests, and some tests need the newer features to work as expected. We also need a version that uses the `babel-remove-types` package that includes the fixes for .gts detyping to work. Because of this update, some slight adjustments are needed to some pod related tests. The `usePods` option of ember-cli-blueprint-test-helpers' `setupPodConfig` util isn't compatible with newer ember-cli versions. As a workaround we use the `--pod` argument when generating files.
This allows users to generate .gjs/.gts templates instead of .hbs templates.
Windvis
force-pushed
the
strict-route-templates-blueprint-support
branch
from
975bd95 to
770cc30
Compare
Windvis
changed the title
--strict-route-template option to the route generator--route-authoring-format option to the route generator
Windvis
changed the title
--route-authoring-format option to the route generator--route-authoring-format option to the route generator
Windvis
changed the title
--route-authoring-format option to the route generator--route-authoring-format option to the route generator
Windvis
commented
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #20800 is merged, it would also be nice if we could generate new routes with a .gjs / .gts template already.
or the shorthand:
or as the project's default by adding
routeAuthoringFormat: 'strict'in .ember-cli