Perf: Bugfix: Don't read before write for anything with a descriptor #19504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
May 24, 2021
|
It's something I feel we should change but it doesn't seem we have a clear path to changing it. Wouldn't might the thoughts of @pzuraq |
|
Is this still relevant? It is a draft PR |
|
its relevant until starbeam, though I'm not sure what the path forward is. @NullVoxPopuli may have a better idea he's been poking around those parts |
|
I don't know what the impact of this PR is, as I have no clue about the older get/set patterns anymore. (I jumped on tracked when 3.13 was canary). Can you rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly opening this to see what tests fail. Currently when using
setorEmberObject.setember will first read a prop before writing to it unless that property happens to have aCOMPUTED_SETTERwhich is only true for things that utilizedtrackedorcomputed. This causes performance issues and bugs when read before write is not expected.