Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX LTS] move LinkTo assertion into a method so LinkToExternal can override #19477

Merged
merged 4 commits into from
Mar 29, 2021
Merged

[BUGFIX LTS] move LinkTo assertion into a method so LinkToExternal can override #19477

merged 4 commits into from
Mar 29, 2021

Conversation

hmajoros
Copy link

@hmajoros hmajoros commented Mar 25, 2021 •
edited
Loading

Part one of a fix for #19459. Once this lands I'll push a change in ember-engines to override this method to just be a noop.

First affected ember version is 3.24

Existing tests continue to pass.

rwjblue
rwjblue requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for picking this up!!

What was the first affected Ember version? If it was 3.24, can you update the commit message and PR title to be prefixed with [BUGFIX lts]?

@hmajoros hmajoros changed the title [BUGFIX] move LinkTo assertion into a method so LinkToExternal can override [BUGFIX lts] move LinkTo assertion into a method so LinkToExternal can override Mar 25, 2021
@hmajoros hmajoros force-pushed the hmajoros/LinkToFix branch from 33e0f8f to 9390895 Compare March 25, 2021 19:23
@hmajoros hmajoros changed the title [BUGFIX lts] move LinkTo assertion into a method so LinkToExternal can override [BUGFIX LTS] move LinkTo assertion into a method so LinkToExternal can override Mar 25, 2021
@hmajoros hmajoros force-pushed the hmajoros/LinkToFix branch from 9390895 to b063c4c Compare March 25, 2021 19:24
@hmajoros hmajoros mentioned this pull request Mar 25, 2021
Closed
@hmajoros hmajoros requested a review from rwjblue March 26, 2021 16:51
@hmajoros hmajoros force-pushed the hmajoros/LinkToFix branch from b063c4c to 8bc1160 Compare March 29, 2021 14:47
@hmajoros hmajoros force-pushed the hmajoros/LinkToFix branch from 8bc1160 to 62e7b92 Compare March 29, 2021 14:49
@rwjblue rwjblue added the Bug label Mar 29, 2021
@rwjblue rwjblue merged commit 20aacf5 into emberjs:master Mar 29, 2021
@rwjblue
Copy link
Member

rwjblue commented Mar 29, 2021

Thank you!

@hmajoros hmajoros deleted the hmajoros/LinkToFix branch March 29, 2021 16:17
@locks locks mentioned this pull request May 20, 2021
Merged
This was referenced Feb 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmajoros @rwjblue