[BUGFIX lts] Prevents infinite rerenders when errors occur during render #19250
+45
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
changed the title
This adds a preventative measure against infinite rerenders that happen due to an unrecoverable error during rendering. This type of error is really annoying from a DX perspective and can really throw developers for a loop. The most common cases appear to be caused by the Ember Inspector, which polls after a render has occured whether on not it was succesful, and in doing so also dirties state, causing a rerender. An example of this is seen in this [example reproduction](https://github.com/xg-wang/getter-error) with the following steps: 1. Load the app 2. Click the To View link to enter the page with the error 3. Open up the Ember Inspector to activate it 4. Reload the page
pzuraq
force-pushed
the
bugfix/prevent-infinite-rerenders-on-error
branch
from
1ec9f6c to
2f8cde9
Compare
rwjblue
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a preventative measure against infinite rerenders that happen
due to an unrecoverable error during rendering. This type of error is
really annoying from a DX perspective and can really throw developers
for a loop. The most common cases appear to be caused by the Ember
Inspector, which polls after a render has occured whether on not it was
succesful, and in doing so also dirties state, causing a rerender.
An example of this is seen in this example reproduction
with the following steps: