[BUGFIX] isEmpty on nested objects #18882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
commented
Apr 18, 2020
| if (objectType === 'object') { | ||
| let length = get(obj, 'length'); | ||
| if (typeof length === 'number') { | ||
| return !length; | ||
| } | ||
| } | ||
|
|
||
| if (typeof obj.length === 'number' && objectType !== 'function') { |
There was a problem hiding this comment.
@rwjblue you had a comment about this check, but removing it made tests fail so I didn't touch it.
There was a problem hiding this comment.
I just don't grok how this can ever be hit. The check just above here is checking all "object"s that have a numeric length property.
There was a problem hiding this comment.
looks like it's true for string case typeof 'foo'.length === 'number' && typeof 'foo' !== 'function'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a re-structuring, it was too much work rebasing or even cherry-picking #16879 (over 300 git conflicts ;_;) so I reimplemented the fix, sorry @janvotava.
Fixes #16879.
Fixes #16878.