Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated _setComputedDecorator #18826

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Remove deprecated _setComputedDecorator #18826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions packages/ember/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,20 +290,6 @@ Ember._tracked = metal.tracked;
computed.alias = metal.alias;
Ember.cacheFor = metal.getCachedValueFor;
Ember.ComputedProperty = metal.ComputedProperty;
Object.defineProperty(Ember, '_setComputedDecorator', {
get() {
deprecate(
'Please migrate from Ember._setComputedDecorator to Ember._setClassicDecorator',
false,
{
id: 'ember._setComputedDecorator',
until: '3.13.0',
}
);

return metal.setClassicDecorator;
},
});
Ember._setClassicDecorator = metal.setClassicDecorator;
Ember.meta = meta;
Ember.get = metal.get;
Expand Down
6 changes: 0 additions & 6 deletions packages/ember/tests/reexports_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,6 @@ moduleFor(
}
}

'@test Ember._setComputedDecorator is deprecated'() {
expectDeprecation(() => {
Ember._setComputedDecorator;
}, 'Please migrate from Ember._setComputedDecorator to Ember._setClassicDecorator');
}

['@test Ember.Resolver is present (but deprecated)'](assert) {
expectDeprecation(() => {
assert.strictEqual(Ember.Resolver, Resolver, 'Ember.Resolver exists');
Expand Down