Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix #18268 query param options not being read #18269

Merged
merged 5 commits into from
Nov 14, 2021
Merged

[BUGFIX] Fix #18268 query param options not being read #18269

merged 5 commits into from
Nov 14, 2021

Conversation

EWhite613
Copy link
Contributor

@EWhite613 EWhite613 commented Aug 14, 2019 •
edited by locks
Loading

Add fix for when queryParams are using a nested value and _optionsForQueryParam not getting the queryParam setting

Fixes #18268.

@EWhite613 EWhite613 changed the title Fix #18268 [BUGFIX] Fix #18268 query param options not being read Aug 23, 2019
@locks locks requested a review from rwjblue April 19, 2020 14:37
@ef4 ef4 merged commit 9c9e418 into emberjs:master Nov 14, 2021
@ef4
Copy link
Contributor

ef4 commented Nov 14, 2021

Thanks for this. Better late than never.

@jaredgalanis jaredgalanis mentioned this pull request Dec 30, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ef4 ef4 ef4 approved these changes

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees

@ef4 ef4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Nested query params don't work with refresh model
2 participants
@EWhite613 @ef4