-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC beta] Octanify documentation #18252
Conversation
fb86889
to
cab3510
Compare
I don't fully understand what the plan here is. Is there any reason we shouldn't land these fixes independently (vs wait for everything to be done in this checklist). |
@rwjblue no reason, I was thinking that we could use this branch to review things before sending them off to master, but we can do that off of master and spare the indirection. I'm updating the instructions and my PR in that direction. |
Closing this as I'm splitting it into multiple PRs. |
Part of #18250.
Missing
mut
inget
documentationcomponent
helperset
andtracked
incomputed_macros
fileeach-in
for correctness/coesion (key is used before it's introduced)get
+mut
example updates properlyaction_handler
switch examples toEmberComponent
so that we can still use the classic.extend
API.observer
isHelper
class exampleRouterService#recognize
uses a strange ember componentMissing code samples
RouterService#isActive
RouterService#recognizeAndLoad
Open questions
class extends Route
vsclass Menu extends Route
) -> namedRouter Service
currentRoute
example is usingnotEmpty
CP decorator. should we replace with native getter? (cc @pzuraq)unless
not
to the framework, and deprecatingunless
for{{if (not)}}
Action Handler
action_handler
remove mixins (?)Controller
Controller#addObserver
- it's currently using an EmberComponent, which seems strangeaction helper
partial
While the partial deprecation is not currently implemented, it is possible that Octane will ship with it.
Regardless, we should definitely suggest GlimmerComponents instead.
Helper (class)
@observer
?Route
on('activate', function(){
+ native class?willTransition
,didTransition
,loading
,error
actions + native class?