[FEAT] assert transitions on destroyed app instances #16386
Conversation
|
|
||
| router.currentRouteName = 'route-a'; | ||
|
|
||
| assert.throws(function() { |
There was a problem hiding this comment.
Since assertions are stripped in production builds (and we run tests against production builds) this will need to be tweaked. The main update should be to replace assert.throws with expectAssertion (which is a global).
|
|
||
| assert.throws(function() { | ||
| router.transitionTo('route-b'); | ||
| }, "A transition was attempted from 'route-a' to 'route-b' but the application instance has already been destroyed."); |
There was a problem hiding this comment.
This will work fine once you migrate to expectAssertion, but I figured I’d point out that this definitely doesn’t do what you expect with assert.throws. Specifically, passing assert.throws two arguments (a function and a string) does not use the provided string as a matcher for the error message but instead uses the second arg as the label for the assertion. It’s a super super trolly api 😭
runspired
force-pushed
the
assert-transitions-on-destroy
branch
from
21b50c4 to
246e16a
Compare
There was a problem hiding this comment.
Failed assertion: Expected failing Ember.assert: 'A transition was attempted from 'route-a' to 'route-b' but the application instance has already been destroyed.', but got 'The route route-b was not found'., expected: A transition was attempted from 'route-a' to 'route-b' but the application instance has already been destroyed.
|
@rwjblue odd. That test was running fine locally. I’ll take a peek. |
No description provided.