[BUGFIX lts] Ensure errors in deferred component hooks can be recovered. #16245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any errors thrown during `didInsertElement` would leave the running environment in an invalid state (`env.inTransaction` would be `true` but `this._transaction` would have been nullified). This commit ensures that we _always_ reset `inTransaction` if `Environment.prototype.commit` is called. Thus avoiding an error RE: "calling commit on null"...
|
we should reserve this as last resort for internal errors |
|
Safe invoke user hooks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any errors thrown during
didInsertElementwould leave the running environment in an invalid state (env.inTransactionwould betruebutthis._transactionwould have been nullified).This commit ensures that we always reset
inTransactionifEnvironment.prototype.commitis called. Thus avoiding an error RE: "calling commit on null"...