RFC#286 | Implement block let helper as syntax #16076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
force-pushed
the
implement-let-helper
branch
from
b08938d to
0612091
Compare
locks
changed the title
locks
force-pushed
the
implement-let-helper
branch
from
0612091 to
060e47b
Compare
GavinJoyce
reviewed
Jan 7, 2018
|
|
||
| ```handlebars | ||
| {{#let | ||
| (concat post ' | The Ember.js Blog' ) |
There was a problem hiding this comment.
nitpick, (concat post ' | The Ember.js Blog')
GavinJoyce
reviewed
Jan 7, 2018
| return `{{#let ${cond} as |test|}}${truthy}{{else}}${falsy}{{/let}}`; | ||
| } | ||
|
|
||
| ['@test keying off of `undefined` does not render']() { |
There was a problem hiding this comment.
I find the description a little hard to parse. Perhaps something like @test a key with an undefined value renders nothing?
There was a problem hiding this comment.
Oops, the tests were adapted from {{with}} and this should not actually pass 🤔 .
There was a problem hiding this comment.
It passes because undefined renders as ``, hah. Adapted the test for {{let}}.
locks
force-pushed
the
implement-let-helper
branch
4 times, most recently
from
6d592ac to
8c48a63
Compare
locks
commented
Jan 8, 2018
| {{/let}} | ||
| ``` | ||
|
|
||
| @method let |
There was a problem hiding this comment.
I am not sure what other annotations to put here.
locks
force-pushed
the
implement-let-helper
branch
from
8c48a63 to
056feb1
Compare
rwjblue
approved these changes
Jan 8, 2018
| that receives a lot of options and you want to clean up the invocation. | ||
|
|
||
| For the following example, the template receives a `post` object with | ||
| `content` and `title` properties, and a `user` object with `firstName` |
There was a problem hiding this comment.
I don't see a user object passed in the example below, maybe that was from a prior iteration?
| `content` and `title` properties, and a `user` object with `firstName` | ||
| and `lastName` properties. | ||
|
|
||
| We are going to call the `my-post` component, passing a title with is |
locks
force-pushed
the
implement-let-helper
branch
from
056feb1 to
614e893
Compare
locks
force-pushed
the
implement-let-helper
branch
from
614e893 to
69c1628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started implementing RFC#286 so developers can start trying it out.
Tasks
let