Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Convert ember-router tests to new style #16015

Merged
merged 1 commit into from
Dec 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 52 additions & 56 deletions packages/ember-routing/tests/ext/controller_test.js
Original file line number Diff line number Diff line change
@@ -1,59 +1,55 @@
import { setOwner } from 'ember-utils';
import { buildOwner } from 'internal-test-helpers';
import { Controller } from 'ember-runtime';

QUnit.module('ember-routing/ext/controller');

QUnit.test('transitionToRoute considers an engine\'s mountPoint', function() {
expect(4);

let router = {
transitionTo(route) {
return route;
}
};

let engineInstance = buildOwner({
ownerOptions: {
routable: true,
mountPoint: 'foo.bar'
}
});

let controller = Controller.create({ target: router });
setOwner(controller, engineInstance);

strictEqual(controller.transitionToRoute('application'), 'foo.bar.application', 'properly prefixes application route');
strictEqual(controller.transitionToRoute('posts'), 'foo.bar.posts', 'properly prefixes child routes');
throws(() => controller.transitionToRoute('/posts'), 'throws when trying to use a url');

let queryParams = {};
strictEqual(controller.transitionToRoute(queryParams), queryParams, 'passes query param only transitions through');
});

QUnit.test('replaceRoute considers an engine\'s mountPoint', function() {
expect(4);

let router = {
replaceWith(route) {
return route;
}
};

let engineInstance = buildOwner({
ownerOptions: {
routable: true,
mountPoint: 'foo.bar'
}
});

let controller = Controller.create({ target: router });
setOwner(controller, engineInstance);

strictEqual(controller.replaceRoute('application'), 'foo.bar.application', 'properly prefixes application route');
strictEqual(controller.replaceRoute('posts'), 'foo.bar.posts', 'properly prefixes child routes');
throws(() => controller.replaceRoute('/posts'), 'throws when trying to use a url');

let queryParams = {};
strictEqual(controller.replaceRoute(queryParams), queryParams, 'passes query param only transitions through');
import { buildOwner, moduleFor, AbstractTestCase } from 'internal-test-helpers';

moduleFor('ember-routing/ext/controller', class extends AbstractTestCase {
['@test transitionToRoute considers an engine\'s mountPoint'](assert) {
let router = {
transitionTo(route) {
return route;
}
};

let engineInstance = buildOwner({
ownerOptions: {
routable: true,
mountPoint: 'foo.bar'
}
});

let controller = Controller.create({ target: router });
setOwner(controller, engineInstance);

assert.strictEqual(controller.transitionToRoute('application'), 'foo.bar.application', 'properly prefixes application route');
assert.strictEqual(controller.transitionToRoute('posts'), 'foo.bar.posts', 'properly prefixes child routes');
assert.throws(() => controller.transitionToRoute('/posts'), 'throws when trying to use a url');

let queryParams = {};
assert.strictEqual(controller.transitionToRoute(queryParams), queryParams, 'passes query param only transitions through');
}

['@test replaceRoute considers an engine\'s mountPoint'](assert) {
let router = {
replaceWith(route) {
return route;
}
};

let engineInstance = buildOwner({
ownerOptions: {
routable: true,
mountPoint: 'foo.bar'
}
});

let controller = Controller.create({ target: router });
setOwner(controller, engineInstance);

assert.strictEqual(controller.replaceRoute('application'), 'foo.bar.application', 'properly prefixes application route');
assert.strictEqual(controller.replaceRoute('posts'), 'foo.bar.posts', 'properly prefixes child routes');
assert.throws(() => controller.replaceRoute('/posts'), 'throws when trying to use a url');

let queryParams = {};
assert.strictEqual(controller.replaceRoute(queryParams), queryParams, 'passes query param only transitions through');
}
});
Loading