Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement template-only components RFC #15974

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Implement template-only components RFC #15974

merged 2 commits into from
Dec 13, 2017

Conversation

chancancode
Copy link
Member

@chancancode chancancode commented Dec 13, 2017 •
edited
Loading

RFC

@chancancode chancancode force-pushed the template-only-component branch from c617d93 to cb8aad2 Compare December 13, 2017 15:33
@chancancode chancancode changed the title [WIP] Implement template-only components RFC Implement template-only components RFC Dec 13, 2017
rwjblue
rwjblue approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! There are some follow-up items that we need to tackle as the RFC progresses (e.g. runtime flag, can we rely on ember-source being consumed as an addon, etc), but those should likely be addressed in a separate PR.

@chancancode chancancode force-pushed the template-only-component branch from beb304e to 0fd6f64 Compare December 13, 2017 16:08
chancancode
chancancode commented Dec 13, 2017
View reviewed changes
packages/ember-glimmer/lib/component-managers/template-only.ts
}

compile(builder: any) {
// TODO: use fromLayout
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @krisselden told me fromLayout is broken on this version of Glimmer, so I didn't bother.

@chancancode chancancode merged commit 9536e13 into master Dec 13, 2017
@chancancode chancancode deleted the template-only-component branch December 13, 2017 16:30
@chancancode chancancode mentioned this pull request Dec 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

@krisselden krisselden Awaiting requested review from krisselden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chancancode @rwjblue