Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move watchedEvents to dev environment #15917

Closed
wants to merge 1 commit into from

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Dec 3, 2017

since watchedEvents is unlikely to be used in production environment moved it to dev

@bekzod
Copy link
Contributor Author

bekzod commented Dec 3, 2017

maybe it is better not to export it in production mode :P

@bekzod
Copy link
Contributor Author

bekzod commented Jan 22, 2018

it is completely removed with #16162

@bekzod bekzod closed this Jan 22, 2018
@bekzod bekzod deleted the move-to-debug branch January 22, 2018 12:37
@mmun
Copy link
Member

mmun commented Jan 22, 2018

Hey @bekzod, I think the idea here is good and the idea definitely crossed my mind. These debugging abilities might come in useful some day (maybe? :P). But I want to do it in a way that has a completely zero footprint if possible. Anyways, just something to think about. And sorry for sweeping the rug out from under you.

@bekzod
Copy link
Contributor Author

bekzod commented Jan 22, 2018

Hi @mmun not at all, I think what you did was great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants