Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate disabledWhen in link-to #15780

Closed
wants to merge 1 commit into from
Closed

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Oct 28, 2017

just to align link-to with other components

@bekzod
Copy link
Contributor Author

bekzod commented Oct 30, 2017

can add tests confirming that disabled works like disabledWhen (by just duplicating disabledWhen tests)

@locks
Copy link
Contributor

locks commented Nov 3, 2017

I'm confused @bekzod, is this attached to an RFC?

@bekzod
Copy link
Contributor Author

bekzod commented Nov 3, 2017

@locks should it have RFC :P ? I think most people would agree that disabledWhen is weird part of link-to which needs ironed out :)

@locks
Copy link
Contributor

locks commented Nov 3, 2017

Yup, it is through deprecation RFCs (in this case) that we communicate changes to the public API to the community. If there is already consensus on deprecating it, it will make for a very quick RFC ;)
Also want to note that new deprecations in 2.x should to be until 3.5.0, to avoid a deprecation explosion before 3.0.0.

@locks locks added the Needs RFC label Nov 3, 2017
@bekzod
Copy link
Contributor Author

bekzod commented Nov 3, 2017

@locks added small rfcs emberjs/rfcs#267

@bekzod bekzod force-pushed the fix-disabled branch 2 times, most recently from 01b473d to df93773 Compare November 3, 2017 15:59
@Serabe
Copy link
Member

Serabe commented Nov 4, 2017

This PR is loosing test coverage. All the tests that were added an expectDeprecation need to be redone for disabled

@bekzod
Copy link
Contributor Author

bekzod commented Nov 4, 2017

@Serabe done

@locks
Copy link
Contributor

locks commented Aug 16, 2019

Closing it since the underlying code has changed significantly, and the router service has shipped meanwhile. Thanks for your continued contributions :)

@locks locks closed this Aug 16, 2019
@bekzod bekzod deleted the fix-disabled branch August 16, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants