-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate disabledWhen
in link-to
#15780
Conversation
can add tests confirming that |
I'm confused @bekzod, is this attached to an RFC? |
@locks should it have RFC :P ? I think most people would agree that |
Yup, it is through deprecation RFCs (in this case) that we communicate changes to the public API to the community. If there is already consensus on deprecating it, it will make for a very quick RFC ;) |
@locks added small rfcs emberjs/rfcs#267 |
01b473d
to
df93773
Compare
This PR is loosing test coverage. All the tests that were added an |
@Serabe done |
Closing it since the underlying code has changed significantly, and the router service has shipped meanwhile. Thanks for your continued contributions :) |
just to align
link-to
with other components