[BUGFIX beta] Ensure Mixin.prototype.toString does not return constructor code #15601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So sorry for letting this linger! Would you mind rebasing to fix the conflict? |
rwjblue
approved these changes
Feb 24, 2018
meslater1030
force-pushed
the
default-mixin-tostring-returns-unknown
branch
from
a8e6652 to
4c4e030
Compare
|
@rwjblue This has been rebased. Thanks for taking a look! |
|
@rwjblue - If this is okay can you merge it? Thank you! |
mmun
force-pushed
the
default-mixin-tostring-returns-unknown
branch
from
1d97eac to
04b04f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #15586. As mentioned in PR #12636 this particular definition of Mixin.prototype.toString is only used when ember-template-compiler.js is loaded before the rest of Ember (or at least that was the case in late 2015). I'm not sure how to write a test for that.