[BUGFIX release] Ensure Ember.Test globals setup when including ember-testing.js #15112
Conversation
|
Looks like Safari bombed out on SauceLabs, due to a timeout. |
|
restarted |
| hasBootstrap: false, | ||
| footer: stripIndent` | ||
| var testing = requireModule('ember-testing'); | ||
| Ember.Test = testing.Test; |
There was a problem hiding this comment.
Is Ember guaranteed to exist here? What happens when you eval ember-testing.js before ember.debug.js or ember.prod.js?
There was a problem hiding this comment.
Yes, due to these lines. I originally had var Ember = requireModule('ember-metal/core'); but that was flagged as a redeclaration.
There was a problem hiding this comment.
Confirmed that this works as intended via shared asset in #15112 (comment)
|
Here's the output of ember-testing.js. |
|
@trentmwillis - The entire build system has changed between release/beta and master, and df839ae cannot be cherry-picked. Would you mind submitting a PR targetting beta with that commit? |
|
@rwjblue, sure, target beta but still tag as |
|
Yes, beta and release are pretty close (the build side is basically the same), so it should still cherry-pick from beta to release. |
|
So turns out this needs to be ported into emberjs-build and then we'll have to bump that package on the beta/release branch here. |
Addressing one part of ember-cli/ember-cli#6870.
After this, it looks like there are other errors that pop-up, but those will be handled in a separate PR.