add a test to prevent regression of #14888 #14889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2017
GavinJoyce
force-pushed
the
gj/failing-test-for-#14888
branch
2 times, most recently
from
351128a to
5b7ff80
Compare
GavinJoyce
changed the title
GavinJoyce
force-pushed
the
gj/failing-test-for-#14888
branch
from
5b7ff80 to
ad19850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had to resort to adding a non-existent
data-ember-action-999999999attribute to the element as I couldn't find a way to exercise theif (action && action.eventName === eventName) {guard without it. The component test doesn't seem to result in afocusoutevent being raised when the element is removed as it does in a production app.This isn't ideal, a change to how we attribute actions to elements mightn't result in this test failing.
/cc @rwjblue perhaps you have some ideas on how we could remove the brittleness from this test?
here's the test failing without #14890: