Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] unregister views from viewRegistry (lts-2-8) #14528

Merged
merged 1 commit into from
Oct 27, 2016
Merged

[BUGFIX release] unregister views from viewRegistry (lts-2-8) #14528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember-glimmer/lib/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ class Renderer {
}

_unregister(view) {
delete this._viewRegistry[this.elementId];
delete this._viewRegistry[view.elementId];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to change here, but this file isn't used at all on 2.8/2.9 (since the ember-glimmer flag is off).

}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/ember-htmlbars/lib/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,12 +255,12 @@ Renderer.prototype.didDestroyElement = function (view) {


Renderer.prototype._register = function Renderer_register(view) {
assert('Attempted to register a view with an id already in use: ' + view.elementId, !this._viewRegistry[this.elementId]);
assert('Attempted to register a view with an id already in use: ' + view.elementId, !this._viewRegistry[view.elementId]);
this._viewRegistry[view.elementId] = view;
};

Renderer.prototype._unregister = function Renderer_unregister(view) {
delete this._viewRegistry[this.elementId];
delete this._viewRegistry[view.elementId];
};

export const InertRenderer = {
Expand Down