Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer 2] failing test for #14001 #14021

Merged
merged 1 commit into from
Aug 30, 2016
Merged

[Glimmer 2] failing test for #14001 #14021

merged 1 commit into from
Aug 30, 2016

Conversation

GavinJoyce
Copy link
Member

@GavinJoyce GavinJoyce commented Aug 4, 2016

Failing test for #14001

screen shot 2016-08-04 at 15 48 55

@GavinJoyce GavinJoyce changed the title failing test for #14001 [Glimmer 2] failing test for #14001 Aug 4, 2016
@rwjblue
Copy link
Member

rwjblue commented Aug 4, 2016

@GavinJoyce - I wonder if we can:

  • remove value from attributeBinding here
  • add a template for it (in this folder) that has a single {{value}} in it

@GavinJoyce
Copy link
Member Author

GavinJoyce commented Aug 4, 2016

@rwjblue spike here : master...GavinJoyce:gj/spike-textarea-template

There are at least two failing tests which I'm looking into now:

screen shot 2016-08-04 at 16 09 40

@rwjblue
Copy link
Member

rwjblue commented Aug 4, 2016

Based on that failing test, I would say that this method isn't firing when those events are triggered.

@GavinJoyce
Copy link
Member Author

GavinJoyce commented Aug 5, 2016

@rwjblue I've pushed a "fix" for that failing test, the htmlbars one has three childNodes (two for wrapping the dynamic node I suspect) while glimmer has just one.

I'm not sure how this strategy would work with user input though, especially in htmlbars. I'd like to write some tests that actually send keys to the text area. Do you know of anything like this elsewhere in ember tests?

@chancancode chancancode merged commit 7351513 into emberjs:master Aug 30, 2016
chancancode added a commit that referenced this pull request Aug 30, 2016
@GavinJoyce GavinJoyce deleted the gj/failing-test-for-GH#14001 branch August 30, 2016 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants