[WIP] [FEATURE beta] Add input and textarea closures #12741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`{{input}}` and `{{textarea}}` are keywords though they resolve to
a component/s. There is no way to use it with the contextual component feature.
This PR adds a contextual version for `input` and `textarea`.
Fixes emberjs#12690
|
Features must go into master behind a feature flag. This change is definitely feature-worthy, I'm not comfortable making it a bugfix. |
|
☔ The latest upstream changes (presumably #12746) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@mixonic can you please close this WIP? Keeping it open does more harm than good. We can revisit once Glimmer components have landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{input}}and{{textarea}}are keywords though they resolve toa component/s. There is no way to use it with the contextual component feature.
This PR adds a contextual version for
inputandtextarea.Fixes #12690