Add a failing test that checks if classNames in DOM reflect the compo… #11609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpauser
force-pushed
the
passing-classnames-to-components
branch
from
8dd6ef5 to
f74c0df
Compare
|
Awesome, thank you for the failing test! |
fpauser
force-pushed
the
passing-classnames-to-components
branch
from
749c2da to
bcb986d
Compare
|
This should have been fixed by #12073, can you rebase to confirm this is passing? |
fpauser
force-pushed
the
passing-classnames-to-components
branch
from
bcb986d to
89ca6d3
Compare
|
I moved my failing test to the 'component - invocation' integration test - it's still failing. As the test shows the classNames are properly concatenated - but there is still a duplicate class in the DOM. Seems like this is more related to concatenated properties 'serialized' to DOM? |
fpauser
force-pushed
the
passing-classnames-to-components
branch
from
89ca6d3 to
4d587dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nents classNames
Failing test for #11600