Assert that readOnly isn't called over CPs with setter #10761
Conversation
| @@ -900,6 +900,16 @@ QUnit.test('is chainable', function() { | |||
| ok(cp instanceof ComputedProperty); | |||
| }); | |||
|
|
|||
| QUnit.test('throws assertion if called over a CP with a setter', function() { | |||
| throws(function() { | |||
There was a problem hiding this comment.
Needs to use expectAssertion (because prod build tests will not throw since asserts are removed from prod builds).
cibernox
force-pushed
the
throw_error_on_readonly_properties_with_setter
branch
2 times, most recently
from
39f3564 to
5b74634
Compare
| set: function() { } | ||
| }).readOnly(); | ||
| }, /Computed properties that define a setter cannot be read-only/); | ||
| ok(true, 'No errors were thrown'); |
There was a problem hiding this comment.
This seems ok, but I don't understand what it is for...
There was a problem hiding this comment.
The last ok? I've seen similar lines in other tests related to assertions, but I agree that is redundant. Gone
cibernox
force-pushed
the
throw_error_on_readonly_properties_with_setter
branch
from
5b74634 to
1eeb925
Compare
…rties_with_setter Assert that readOnly isn't called over CPs with setter
|
Thank you! |
|
This should not generate an exception, as this is a breaking change that causes apps that happened to have an extra unused argument in their CP functions to break. We can deprecate it in 1.x and cause it to raise in 2.x. |
|
I haven't considered that, you're right, it's beaking. |
In preparation for emberjs/rfcs#12
Ensure that an error is thrown is
readOnlyis invoked over CP's that defines a setter function. It is conceptually absurd.