[BUGFIX beta] fix ES3 compatibility #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1011,7 +1011,7 @@ function appendLiveRoute(liveRoutes, route, parentRoute, defaultParentState, ren | |||
| var target; | |||
| var myState = { | |||
| render: renderOptions, | |||
| outlets: Object.create(null) | |||
| outlets: Ember.create(null) | |||
There was a problem hiding this comment.
This is available as a utility:
import o_create from "ember-metal/platform/create";Example:
There was a problem hiding this comment.
Ok, cool, I'll switch to that.
@machty pointed out that emberjs#10372 uses an ES5-only feature.
ef4
force-pushed
the
decouple-outlets-es3
branch
from
db63012 to
4850e09
Compare
ef4
added a commit
that referenced
this pull request
Feb 8, 2015
[BUGFIX beta] fix ES3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@machty pointed out that #10372 uses an ES5-only feature.