[DOC] Add inline docs to stream util methods and rename chainStream to chain. #10105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good.
|
|
Thanks @mmun I'll mark them private for now and we can decide whether to expose them as public API over time. Also will rename |
lukemelia
force-pushed
the
document-stream-utils
branch
from
036c39a to
f15f9f7
Compare
lukemelia
changed the title
|
OK, all set from my perspective (pending a green build!). |
lukemelia
force-pushed
the
document-stream-utils
branch
from
f15f9f7 to
7ef2dc1
Compare
lukemelia
force-pushed
the
document-stream-utils
branch
from
7ef2dc1 to
f0db31e
Compare
|
|
||
| @private | ||
| @function chain | ||
| @param {Object|Stream} array An array containing zero or more stream objects |
There was a problem hiding this comment.
Whoops, good catch. Will fix.
rwjblue
added a commit
that referenced
this pull request
Jan 1, 2015
[DOC] Add inline docs to stream util methods and rename chainStream to chain.
|
Thanks Luke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mixonic spin-off of your pointers about the non-stream-safe util methods from #10093