Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering perfomance issue with each and tables #18834

Closed
dgavey opened this issue Mar 23, 2020 · 0 comments · Fixed by #18861
Closed

Rendering perfomance issue with each and tables #18834

dgavey opened this issue Mar 23, 2020 · 0 comments · Fixed by #18861

Comments

@dgavey
Copy link

dgavey commented Mar 23, 2020

This is extended from a conversation on Discord.

I discovered a significant rendering performance issue in my app. After refactoring a table I was seeing a new significant delay after a click when rendering some table rows.

@pzuraq Asked if I could try with a production build. The performance was significantly better than the development build. He thought perhaps it was another instance of a known issue with "Error slowness"

I have created a simple reproduction of the error here -> https://github.com/dgavey/ember-table-rendering-performance . There is a checkbox that either renders the columns of the table using an each for the column display, or skips the each and just renders every column.

If the checkbox is on, the initial rendering of the table is quite a bit slower than it is when it's off. This was evaluated in a development build.

In a production build, the render time between options seems to be much closer.

In this reproduction the render difference does not seem to be any where near as dramatic as it is in my app, but so far this is the closest I could come to finding where the performance difference was while keeping the reproduction simple.

rwjblue added a commit to rwjblue/ember.js that referenced this issue Apr 3, 2020
…formance.

Removes capturing stack traces for all tracked items, as just calling
`new Error()` ends up taking quite a bit of time.

Fixes emberjs#18834
Fixes emberjs#18798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant