Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mainContext is undefined in ember-environment/lib/global.js #14859

Closed
zoltan-nz opened this issue Jan 21, 2017 · 2 comments
Closed

mainContext is undefined in ember-environment/lib/global.js #14859

zoltan-nz opened this issue Jan 21, 2017 · 2 comments

Comments

@zoltan-nz
Copy link
Contributor

zoltan-nz commented Jan 21, 2017 •
edited
Loading

After the ESLint warning cleanup the mainContext is undefined and brake the ember-template-compiler.js compilation in grunt environment.

Previous conversation about this issue:
e24e403#diff-5b2ea89606fd2097e9e17d66ae54ed51L2

Opened issue in grunt-ember-templates repo: dgeb/grunt-ember-templates#94

cc @Turbo87 @andyhot
@zoltan-nz zoltan-nz changed the title mainContext is undefined in ember-environment/lib/globa.js mainContext is undefined in ember-environment/lib/global.js Jan 21, 2017
zoltan-nz added a commit to zoltan-nz/ember.js that referenced this issue Jan 21, 2017
@zoltan-nz
[BUGFIX beta] Remove mainContext from global.js fix emberjs#14859
fa91e8c
@zoltan-nz zoltan-nz mentioned this issue Jan 21, 2017
Merged
zoltan-nz added a commit to zoltan-nz/ember.js that referenced this issue Jan 21, 2017
@zoltan-nz
[BUGFIX beta] Add back mainContext to loader emberjs#14859
6ec4747
rwjblue added a commit that referenced this issue Jan 22, 2017
@rwjblue
Merge pull request #14860 from zoltan-nz/master
70a94bb 
[BUGFIX beta] Add back mainContext to loader #14859
rwjblue pushed a commit that referenced this issue Feb 16, 2017
@zoltan-nz @rwjblue
[BUGFIX beta] Add back mainContext to loader #14859
e6d4e8b 
(cherry picked from commit 6ec4747)
rwjblue pushed a commit that referenced this issue Feb 16, 2017
@zoltan-nz @rwjblue
[BUGFIX beta] Add back mainContext to loader #14859
bb803e2 
(cherry picked from commit 6ec4747)
@mixonic
Copy link
Member

mixonic commented Mar 26, 2017

@zoltan-nz is this issue still valid?

@rwjblue rwjblue closed this as completed Mar 26, 2017
@rwjblue
Copy link
Member

rwjblue commented Mar 26, 2017

No it was cleaned up in a followup pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mixonic @rwjblue @zoltan-nz