Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ember.K #14746

Closed
3 tasks done
cibernox opened this issue Dec 21, 2016 · 2 comments
Closed
3 tasks done

Deprecate Ember.K #14746

cibernox opened this issue Dec 21, 2016 · 2 comments

Comments

@cibernox
Copy link
Contributor

cibernox commented Dec 21, 2016

Now that the RFC to deprecate Ember.K has been merged, this is a pretty simple task to implement, and one that is perfect for a new contributor to perform since it's not technically complex and it balanced between documentation and implementation.

The tasks to perform are divided in a couple repositories:

  • Read the RFC, to understand the motivation and the outcome.
  • Amend the deprecations guide in the website reporsitory.
    Information of the deprecation:
    id: ember-metal.ember-k
    until: 3.0.0
    explanation:
    The entry must explain how to automatically remove usages of Ember.K in your codebase using ember-watson.
    It must also explain that there is two options on the command: --empty and --return-this
    and that while the second is 100% compatible, the first is probably what they want. Check the
    addendum on the RFC for more information.
  • Create a PR in Ember.js itselt deprecating Ember.K.
    As stated in the previous point, the id of the deprecation must be ember-metal.ember-k and the
    url must point to the entry in the deprecation guide you've just created.
    If you are not familiar with how deprecations are made, this is a good example of how the id, until and url are used

If anyone wants to go and deprecate this, I can provide support or guidance on the process. Feel free to ping me in Slack on here anytime.

@givanse
Copy link

givanse commented Dec 23, 2016

PRs up, please let me know what changes should I make.

#14751
emberjs/website#2774

@rwjblue
Copy link
Member

rwjblue commented Dec 26, 2016

I believe this is done, thanks to all those who helped out!

@rwjblue rwjblue closed this as completed Dec 26, 2016
sbatson5 pushed a commit to adopted-ember-addons/ember-cli-flash that referenced this issue Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants