Component positional params don't update when used with the component helper

[GavinJoyce]

I came across this when porting component helper tests to Glimmer2.

Twiddle: https://ember-twiddle.com/8bd17b5f64fdf1f400d8

When this is fixed, please uncomment https://github.com/emberjs/ember.js/pull/13140/files#r56916691

[rwjblue]

This works properly in the glimmer implementation but not HTMLBars or it doesn't work in either case?

[GavinJoyce]

I don't believe positional params have been implemented in glimmer yet
On 21 Mar 2016 6:02 p.m., "Robert Jackson" [email protected] wrote:

This works properly in the glimmer implementation but not HTMLBars or it
doesn't work in either case?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#13158 (comment)

[GavinJoyce]

From #13127:

[pixelhandler]

@GavinJoyce I'm curious in the twiddle example regarding using positionalParams in two separate component that both use Ember.Component.reopenClass to do the same thing. Is that how you would used positional params in an app? or would you extend the component then reopenClass ?

[GavinJoyce]

@pixelhandler thanks, my mistake. I've updated the twiddle, the bug is still present. I'll update the tests in ember.js too, they currently do Ember.Component.reopenClass.

TODO:

• update ember.js tests : updated tests to reopen extended Components #13184

[locks]

@Serabe can you review?

[Serabe]

Yes. A quick test shows that for rest pos params it only updates for the first one (😲). I'm working on other parts of positional parameters, so I'll take a look while at it.

[Serabe]

#13435 fixes this problem in HTMLBars. Glimmer 2 support for positional parameters is on its way (#13393) and won't need a fix.