[FEAT] assert-send-on-destroy

packages/ember-glimmer/tests/integration/components/target-action-test.js

@@ -1,4 +1,5 @@
 import { assign } from 'ember-utils';
+import { runDestroy } from "internal-test-helpers";
 import {
   moduleFor,
   RenderingTest,
@@ -259,6 +260,34 @@ moduleFor('Components test: sendAction', class extends RenderingTest {
 
     this.runTask(() => innerChild.sendAction('bar', 'something special'));
   }
+
+  ['@test asserts if called on a destroyed component']() {
+    let component;
+
+    this.registerComponent('rip-alley', {
+      ComponentClass: Component.extend({
+        init() {
+          this._super();
+          component = this;
+        },
+
+        toString() {
+          return 'component:rip-alley';
+        }
+      })
+    });
+
+    this.render('{{rip-alley}}');
+
+    runDestroy(component);
+
+    expectAssertion(
+      () => {
+        component.sendAction('trigger-me-dead');
+      },
+      "Attempted to call .sendAction() with the action 'trigger-me-dead' on the destroyed object 'component:rip-alley'."
+    );
+  }
 });
 
 moduleFor('Components test: sendAction to a controller', class extends ApplicationTest {
@@ -617,4 +646,32 @@ moduleFor('Components test: send', class extends RenderingTest {
       actions: ['foo']
     });
   }
+
+  ['@test asserts if called on a destroyed component']() {
+    let component;
+
+    this.registerComponent('rip-alley', {
+      ComponentClass: Component.extend({
+        init() {
+          this._super();
+          component = this;
+        },
+
+        toString() {
+          return 'component:rip-alley';
+        }
+      })
+    });
+
+    this.render('{{rip-alley}}');
+
+    runDestroy(component);
+
+    expectAssertion(
+      () => {
+        component.send('trigger-me-dead');
+      },
+      "Attempted to call .send() with the action 'trigger-me-dead' on the destroyed object 'component:rip-alley'."
+    );
+  }
 });

packages/ember-routing/lib/system/route.js

@@ -1272,6 +1272,10 @@ let Route = EmberObject.extend(ActionHandler, Evented, {
     @public
   */
   send(...args) {
+    assert(
+      `Attempted to call .send() with the action '${args[0]}' on the destroyed route '${this.routeName}'.`,
+      !this.isDestroying && !this.isDestroyed
+    );
     if ((this._router && this._router._routerMicrolib) || !isTesting()) {
       this._router.send(...args);
     } else {

packages/ember-routing/tests/system/route_test.js

@@ -193,6 +193,18 @@ moduleFor('Route', class extends AbstractTestCase {
     assert.equal(false, route.send('returnsFalse'));
     assert.equal(undefined, route.send('nonexistent', 1, 2, 3));
   }
+
+  ['@test .send asserts if called on a destroyed route']() {
+    route.routeName = 'rip-alley';
+    runDestroy(route);
+
+    expectAssertion(
+      () => {
+        route.send('trigger-me-dead');
+      },
+      "Attempted to call .send() with the action 'trigger-me-dead' on the destroyed route 'rip-alley'."
+    );
+  }
 });
 
 moduleFor('Route serialize', class extends AbstractTestCase {

packages/ember-runtime/lib/mixins/action_handler.js

@@ -197,6 +197,10 @@ const ActionHandler = Mixin.create({
     @public
   */
   send(actionName, ...args) {
+    assert(
+      `Attempted to call .send() with the action '${actionName}' on the destroyed object '${this}'.`,
+      !this.isDestroying && !this.isDestroyed
+    );
     if (this.actions && this.actions[actionName]) {
       let shouldBubble = this.actions[actionName].apply(this, args) === true;
       if (!shouldBubble) { return; }

packages/ember-runtime/tests/controllers/controller_test.js

@@ -5,7 +5,7 @@ import Service from '../../system/service';
 import { Mixin, get } from 'ember-metal';
 import EmberObject from '../../system/object';
 import inject from '../../inject';
-import { buildOwner } from 'internal-test-helpers';
+import { runDestroy, buildOwner } from 'internal-test-helpers';
 
 QUnit.module('Controller event handling');
 
@@ -82,6 +82,26 @@ QUnit.test('Action can be handled by a superclass\' actions object', function(as
   controller.send('baz');
 });
 
+QUnit.test('.send asserts if called on a destroyed controller', function() {
+  let owner = buildOwner();
+
+  owner.register('controller:application', Controller.extend({
+    toString() {
+      return 'controller:rip-alley';
+    }
+  }));
+
+  let controller = owner.lookup('controller:application');
+  runDestroy(owner);
+
+  expectAssertion(
+    () => {
+      controller.send('trigger-me-dead');
+    },
+    "Attempted to call .send() with the action 'trigger-me-dead' on the destroyed object 'controller:rip-alley'."
+  );
+});
+
 QUnit.module('Controller deprecations');
 
 QUnit.module('Controller Content -> Model Alias');

packages/ember-views/lib/mixins/action_support.js

@@ -109,6 +109,11 @@ export default Mixin.create({
     @public
   */
   sendAction(action, ...contexts) {
+    assert(
+      `Attempted to call .sendAction() with the action '${action}' on the destroyed object '${this}'.`,
+      !this.isDestroying && !this.isDestroyed
+    );
+
     let actionName;
 
     // Send the default action
@@ -132,6 +137,11 @@ export default Mixin.create({
   },
 
   send(actionName, ...args) {
+    assert(
+      `Attempted to call .send() with the action '${actionName}' on the destroyed object '${this}'.`,
+      !this.isDestroying && !this.isDestroyed
+    );
+
     let action = this.actions && this.actions[actionName];
 
     if (action) {