Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Explain the (un)safety of the type of
getOwner()
The type for `getOwner()` is *technically* unsafe, but this unsafety is one which end users will rarely hit in practice and, courtesy of Ember's current types, is unavoidable if `getOwner(someService)` is to correctly return `Owner` instead of `Owner | undefined`. The Typed Ember folks have discussed this point at some length, but I realized on looking at this to make the changes in the preceding two commits that we didn't have it committed to the code base anywhere, so here I am just introducing a long comment explaining it. When we switch from preview to stable types, this comment should come along!
- Loading branch information